Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realize generic navigation structure #3472

Merged
merged 14 commits into from
Jun 26, 2024
Merged

Realize generic navigation structure #3472

merged 14 commits into from
Jun 26, 2024

Conversation

Drodt
Copy link
Member

@Drodt Drodt commented May 22, 2024

Related Issue

This pull request depends on #3436.

Intended Change

Previously, the SyntaxElement interface was introduced with the intent of a common supertype and navigation structure for generic AST elements. This PR adds functionality for navigation through ASTs. It serves as a ground for a rewrite of AST visitors, walkers, and matching; each of which will have their separate PR.

Type of pull request

  • Refactoring (behaviour should not change or only minimally change)
  • New feature (non-breaking change which adds functionality)
  • There are changes to the (Java) code

Ensuring quality

  • I made sure that the introduced/changed code is well documented (Javadoc and inline comments).
  • I have tested the feature as follows: automatic tests

Additional information and contact(s)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

@Drodt Drodt added 🛠 Maintenance Code quality and related things w/o functional changes RFC "Request for comments" is the appeal for making and expressing your opinion on a topic. labels May 22, 2024
@Drodt Drodt requested a review from unp1 May 22, 2024 09:07
@Drodt Drodt self-assigned this May 22, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 43.03030% with 94 lines in your changes missing coverage. Please review.

Project coverage is 38.04%. Comparing base (1b48b9e) to head (a4de274).
Report is 92 commits behind head on main.

Files Patch % Lines
...core/src/main/java/org/key_project/logic/Term.java 0.00% 11 Missing ⚠️
...src/main/java/de/uka/ilkd/key/logic/JavaBlock.java 0.00% 6 Missing ⚠️
.../uka/ilkd/key/speclang/DependencyContractImpl.java 0.00% 6 Missing ⚠️
...c/main/java/org/key_project/logic/op/Modality.java 0.00% 6 Missing ⚠️
...e/uka/ilkd/key/logic/op/SortDependingFunction.java 28.57% 5 Missing ⚠️
...ava/de/uka/ilkd/key/logic/op/ElementaryUpdate.java 0.00% 4 Missing ⚠️
...ava/de/uka/ilkd/key/logic/op/ObserverFunction.java 33.33% 4 Missing ⚠️
...src/main/java/de/uka/ilkd/key/pp/LogicPrinter.java 0.00% 3 Missing and 1 partial ⚠️
...ava/org/key_project/logic/SyntaxElementCursor.java 89.74% 4 Missing ⚠️
...java/de/uka/ilkd/key/logic/op/ProgramVariable.java 0.00% 3 Missing ⚠️
... and 25 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3472      +/-   ##
============================================
+ Coverage     38.03%   38.04%   +0.01%     
- Complexity    17089    17117      +28     
============================================
  Files          2099     2105       +6     
  Lines        127274   127439     +165     
  Branches      21386    21401      +15     
============================================
+ Hits          48409    48487      +78     
- Misses        72892    72978      +86     
- Partials       5973     5974       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobias-rnh
Copy link
Contributor

Can you add functionality to the SyntaxElementCursor to go to the next node in the tree?

@Drodt
Copy link
Member Author

Drodt commented Jun 5, 2024

Can you add functionality to the SyntaxElementCursor to go to the next node in the tree?

Done!

@unp1 unp1 mentioned this pull request Jun 13, 2024
4 tasks
@Drodt Drodt enabled auto-merge June 26, 2024 07:36
@unp1 unp1 removed the RFC "Request for comments" is the appeal for making and expressing your opinion on a topic. label Jun 26, 2024
@Drodt Drodt added this pull request to the merge queue Jun 26, 2024
Merged via the queue into KeYProject:main with commit ed267fd Jun 26, 2024
14 of 15 checks passed
@Drodt Drodt deleted the traversal branch June 26, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 Maintenance Code quality and related things w/o functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants